Difference: EventModelReview (1 vs. 35)

Revision 352007-10-29 - StephenWotton

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Revision 342007-01-16 - MarcoCattaneo

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 94 to 94
 

ST:

  • Information provider: Matt Needham
Changed:
<
<
>
>
 

Revision 332006-05-18 - MarcoCattaneo

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Added:
>
>

Warning

This page and connected pages document the Event Model review that took place in summer and autumn 2005. Its contents document the event model at the time of the review. This is not an up to date documentation of the many event model changes that took place after the review
 

Introduction

Revision 322006-02-07 - PeterJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 67 to 67
 

Persistent base classes (DataObject, Keyed Objects)

  • Information provider: M.Frank
  • Reviewers: Olivier Callot, Stefan Roiser
Changed:
<
<
>
>
 

Linkers

Line: 88 to 88
 
Changed:
<
<
>
>
 

ST:

Changed:
<
<
>
>
 

OT:

  • Information provider: Jacopo Nardulli
  • Information source: See OTEventModel

Revision 312005-09-16 - OlivierCallotSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 67 to 67
 

Persistent base classes (DataObject, Keyed Objects)

  • Information provider: M.Frank
  • Reviewers: Olivier Callot, Stefan Roiser
Added:
>
>
 

Linkers

  • Information provider: Olivier Callot

Revision 302005-09-05 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 107 to 107
 

Muon:

  • Information provider: Alessia Satta
  • Information sources: see MuonEventModel.
Added:
>
>
 
  • Reviewers: Olivier Leroy, Chris Jones

Calo:

Revision 292005-08-29 - unknown

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 86 to 86
 
Changed:
<
<
>
>
 

ST:

Revision 282005-08-22 - OlivierCallotSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 70 to 70
 

Linkers

  • Information provider: Olivier Callot
Changed:
<
<
  • Information sources: ?
>
>
 
  • Reviewers: Markus Frank, Patrick Koppenburg

Rdst, Data compression :

Revision 272005-08-22 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 101 to 101
 

RICH:

  • Information provider: Chris Jones
  • Information sources: For details on the RICH Event model, see RichEventModel. For more details on the overall software structure, see RichSoftware.
Added:
>
>
 
  • Reviewers: Matt Needham, Alessia Satta

Muon:

Revision 262005-08-19 - PhilippeCharpentier

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 65 to 65
 
  • Reviewers: Marco Cattaneo, Gloria Corti

Persistent base classes (DataObject, Keyed Objects)

Changed:
<
<
  • Information provider:
>
>
  • Information provider: M.Frank
 
  • Reviewers: Olivier Callot, Stefan Roiser

Linkers

Revision 252005-08-17 - unknown

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 86 to 86
 
Changed:
<
<
>
>
 

ST:

Changed:
<
<
>
>
 

OT:

  • Information provider: Jacopo Nardulli
  • Information source: See OTEventModel

Revision 242005-08-17 - PatrickSKoppenburg

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 21 to 21
 
  • Are there data members that could usefully be added
Changed:
<
<
  • For a given output format (Sim, Digi, Dst) are there "summary" classes that could be added, allowing removal of more bulky information (e.g. Velo dEdx would allow removal of VeloClustersOnTrack)
>
>
  • For a given output format (Sim, Digi, Dst) are there "summary" classes that could be added, allowing removal of more bulky information (e.g. Velo dEdx would allow removal of VeloClustersOnTrack)
 
  • Is there commonality between classes (e.g. can we simplify by adopting MCHit in Velo and Muon)?
Line: 30 to 30
 
  • Can something be gained in Raw/L1 bank formats

  • How are relations to other classes done?
Changed:
<
<
    • Usage of SmartRef (can it be minimised, use key instead ?)
>
>
    • Usage of SmartRef (can it be minimised, use key instead ?)
 
    • Are all necessary Linker associators available?
Changed:
<
<
>
>
  • Do we always need KeyedObject (maybe some can be simple objects in a std::vector DataObject?)
 
  • Is anything handcoded that could be generated by G.O.D. (either with existing directives or simple new features)
Line: 66 to 66
 

Persistent base classes (DataObject, Keyed Objects)

  • Information provider:
Deleted:
<
<
 
  • Reviewers: Olivier Callot, Stefan Roiser
Added:
>
>

Linkers

  • Information provider: Olivier Callot
  • Information sources: ?
  • Reviewers: Markus Frank, Patrick Koppenburg
 

Rdst, Data compression :

  • Reviewers: Markus Frank, Stefan Roiser

Physics:

Changed:
<
<

PHYS + Parts of MC model (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

>
>

PHYS + Parts of MC model (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

 
  • Information provider: Physics event model task force (Patrick Koppenburg et al.). See Physics Event Model Task Force pages.
  • Reviewers: Done internally by task force, detailed report during September LHCb software week

Revision 232005-08-04 - ChrisParkes

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 80 to 80
 

VELO:

  • Information provider: Chris Parkes
Added:
>
>
 
  • Reviewers: Matt Needham, Juan Palacios

ST:

Revision 222005-08-01 - GerhardRaven

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 115 to 115
 

Track event model:

  • Information provider: Eduardo Rodrigues Figueiredo, Jose A. Hernando
Added:
>
>
 
  • Review: Detailed presentation from track event model task force during September LHCb software week including feedback from current users of the new track event model

Timescale

Revision 212005-08-01 - RobertaSantacesaria

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 100 to 100
 

Muon:

  • Information provider: Alessia Satta
Added:
>
>
 
  • Reviewers: Olivier Leroy, Chris Jones

Calo:

Revision 202005-07-28 - unknown

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 41 to 41
 
    • Usage of C++ concepts
    • Efficiency for usage in code
Added:
>
>
  • Identify the use of CLHEP Vector, Geometry and Matrix classes. How easy or difficult will it be to migrate to the new MathLib libraries? A preliminary list of CLHEP uses in the Event Model classes can be found in this TWiki.
    • Used in implementation?
    • Used in public interface?
    • Used in interaction with code external to the package under review?
-- JuanPalacios - 28 Jul 2005
 

Division of work

The proposal is to divide the work in the following way:

Revision 192005-07-28 - MatthewDavidNeedhamSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 77 to 77
 

ST:

  • Information provider: Matt Needham
Added:
>
>
 
  • Reviewers: Chris Parkes, Juan Palacios

OT:

Revision 182005-07-26 - PatrickSKoppenburg

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 98 to 98
 
  • Information sources: see CaloEventModel.
  • Reviewers: Olivier Leroy, Chris Jones
Changed:
<
<

L0, L1 :

>
>

L0, L1, HLT :

 
  • Information provider: Olivier Callot, Thomas Schietinger, Patrick Koppenburg
Changed:
<
<
>
>
 
  • Reviewers: Olivier Deschamp, Alessia Satta

Track event model:

Revision 172005-07-26 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 68 to 68
 

Physics:

PHYS + Parts of MC model (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

Changed:
<
<
  • Information provider: Physics event model task force (Patrick Koppenburg et al.)
>
>
 
  • Reviewers: Done internally by task force, detailed report during September LHCb software week

VELO:

Revision 162005-07-26 - OlivierCallotSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 100 to 100
 

L0, L1 :

  • Information provider: Olivier Callot, Thomas Schietinger, Patrick Koppenburg
Added:
>
>
 
  • Reviewers: Olivier Deschamp, Alessia Satta

Track event model:

Revision 152005-07-21 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Revision 142005-07-15 - OlivierDeschampsSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 95 to 95
 

Calo:

  • Information provider: Olivier Deschamps
Added:
>
>
 
  • Reviewers: Olivier Leroy, Chris Jones

L0, L1 :

Revision 132005-07-15 - MarcoCattaneo

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 50 to 50
 

LHCbID, RawBuffer, L1Buffer

  • information provider: Marco Cattaneo, help from Eduardo Rodrigues Figueiredo, Jose A. Hernando, Helder Lopes
Added:
>
>
 
  • Reviewers: Chris Jones, Gloria Corti

MCHit

Revision 122005-07-14 - MarkusFrankSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 123 to 123
 
MarcoCattaneo - 05 Jul 2005
Changed:
<
<
META FILEATTACHMENT attr="" comment="BasicObjects" date="1121327488" name="BasicObjects.html" path="C:\Documents and Settings\frankb\My Documents\BasicObjects.html" size="2220" user="frankb" version="1.1"
>
>
META FILEATTACHMENT attr="h" comment="BasicObjects" date="1121327488" name="BasicObjects.html" path="C:\Documents and Settings\frankb\My Documents\BasicObjects.html" size="2220" user="frankb" version="1.1"

Revision 112005-07-14 - MarkusFrankSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 56 to 56
 
  • information providers: subsystems
  • Reviewers: Marco Cattaneo, Gloria Corti
Changed:
<
<

Persistent base classes (DataObject, Keyed Objects)

>
>

Persistent base classes (DataObject, Keyed Objects)

 
  • Information provider:

  • Reviewers: Olivier Callot, Stefan Roiser

Revision 102005-07-14 - MarkusFrankSecondary

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 56 to 56
 
  • information providers: subsystems
  • Reviewers: Marco Cattaneo, Gloria Corti
Changed:
<
<

Persistent base classes (data object, keyed container )

  • Information provider: ?
>
>

Persistent base classes (DataObject, Keyed Objects)

  • Information provider:

 
  • Reviewers: Olivier Callot, Stefan Roiser

Rdst, Data compression :

Line: 122 to 123
 
MarcoCattaneo - 05 Jul 2005
Added:
>
>
META FILEATTACHMENT attr="" comment="BasicObjects" date="1121327488" name="BasicObjects.html" path="C:\Documents and Settings\frankb\My Documents\BasicObjects.html" size="2220" user="frankb" version="1.1"

Revision 92005-07-13 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 30 to 30
 
  • Can something be gained in Raw/L1 bank formats

  • How are relations to other classes done?
Changed:
<
<
    • Usage of SmartRef (can it be minimised ?)
>
>
    • Usage of SmartRef (can it be minimised, use key instead ?)
 
    • Are all necessary Linker associators available?

Revision 82005-07-13 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"
Changed:
<
<

LHCb Event Model Review

>
>

LHCb Event Model Review

 

Introduction

Line: 26 to 30
 
  • Can something be gained in Raw/L1 bank formats

  • How are relations to other classes done?
Changed:
<
<
. Usage of SmartRef (can it be minimised, use key instead?) . Are all necessary Linker associators available?
>
>
    • Usage of SmartRef (can it be minimised ?)
    • Are all necessary Linker associators available?
 
Changed:
<
<
  • Is anything handcoded that could be generated bu GOD (either with existing directives or simple new features)
>
>
  • Is anything handcoded that could be generated by G.O.D. (either with existing directives or simple new features)
 
  • Design issues:
Changed:
<
<
. Usage of C++ concepts . Efficiency for usage in code
>
>
    • Usage of C++ concepts
    • Efficiency for usage in code
 

Division of work

Revision 72005-07-13 - ChristopherRJones

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 62 to 62
 

Physics:

Changed:
<
<

PHYS + part of MC (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

>
>

PHYS + Parts of MC model (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

 
  • Information provider: Physics event model task force (Patrick Koppenburg et al.)
Changed:
<
<
  • Reviewers: done internally by task force, detailed report during September LHCb software week
>
>
  • Reviewers: Done internally by task force, detailed report during September LHCb software week
 

VELO:

  • Information provider: Chris Parkes
Line: 81 to 81
 

RICH:

  • Information provider: Chris Jones
Changed:
<
<
>
>
  • Information sources: For details on the RICH Event model, see RichEventModel. For more details on the overall software structure, see RichSoftware.
 
  • Reviewers: Matt Needham, Alessia Satta

Muon:

Line: 116 to 116
 
Changed:
<
<
-- MarcoCattaneo - 05 Jul 2005
>
>

MarcoCattaneo - 05 Jul 2005
 

Revision 22005-07-05 - ThomasRuf

Line: 1 to 1
 
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Line: 64 to 64
 

Physics:

PHYS + part of MC (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

  • Information provider: Physics event model task force (Patrick Koppenburg et al.)
Changed:
<
<
  • Reviewers: Gerhard van Raven and Gloria Corti
>
>
  • Reviewers: done internally by task force, detailed report during September LHCb software week
 

VELO:

  • Information provider: Chris Parkes
Line: 95 to 94
 
  • Information provider: Olivier Callot, Thomas Schietinger, Patrick Koppenburg
  • Reviewers: Olivier Deschamp, Alessia Satta
Added:
>
>

Track event model:

  • Information provider: Eduardo Rodrigues Figueiredo, Jose A. Hernando
  • Review: Detailed presentation from track event model task force during September LHCb software week including feedback from current users of the new track event model
 

Timescale

First phase, July:

The information providers set-up a web page with links to relevant information, provide explanations for specific implementations, etc. Please link the web page to this page

Revision 12005-07-05 - MarcoCattaneo

Line: 1 to 1
Added:
>
>
META TOPICPARENT name="LHCbComputing"

LHCb Event Model Review

Introduction

The LHCb event model classes are the basis of our software. Changes to these classes make it very difficult to maintain backward compatibility of our software. Starting to modify these classes during data taking is not recommended. But even modifying them next year should be avoided as much as possible, because the the last big MC data production is supposed to start ~January 2006, and not being able to use this data set for exercising our reconstruction, trigger and analysis software before the beam starts would be a pity.

It is therefore important that we have a serious review of all the different event model classes and having the required modifications in place at the end of this year (2005).

It is quite some effort to have this review, but we are confident that it will pay off when data taking starts. Rather than nominating a few people reviewing everything, the proposal is to share the work of reviewing among all subsystems. Please find below the proposed division of work and planning.

Some guidelines for the review

  • Are there any classes that are obsolete (no longer used anywhere)
  • Are there any classes that are unneccessary (e.g. xxDigits, since one could access RawBuffer directly)

  • Are there any unnecessary data members (e.g., for MCRichHits, inheritance to MCHits was removed because exit point does not make sense)
  • Are there data members that could usefully be added

  • For a given output format (Sim, Digi, Dst) are there "summary" classes that could be added, allowing removal of more bulky information (e.g. Velo dEdx would allow removal of VeloClustersOnTrack)

  • Is there commonality between classes (e.g. can we simplify by adopting MCHit in Velo and Muon)?
  • Is structure in TES reasonable (e.g. multiple containers for Muon...)

  • Can something be gained in Raw/L1 bank formats

  • How are relations to other classes done? . Usage of SmartRef (can it be minimised, use key instead?) . Are all necessary Linker associators available?

  • Is anything handcoded that could be generated bu GOD (either with existing directives or simple new features)

  • Design issues: . Usage of C++ concepts . Efficiency for usage in code

Division of work

The proposal is to divide the work in the following way:

LHCb generic base classes:

LHCbID, RawBuffer, L1Buffer

  • information provider: Marco Cattaneo, help from Eduardo Rodrigues Figueiredo, Jose A. Hernando, Helder Lopes
  • Reviewers: Chris Jones, Gloria Corti

MCHit

  • information providers: subsystems
  • Reviewers: Marco Cattaneo, Gloria Corti

Persistent base classes (data object, keyed container )

  • Information provider: ?
  • Reviewers: Olivier Callot, Stefan Roiser

Rdst, Data compression :

  • Reviewers: Markus Frank, Stefan Roiser

Physics:

PHYS + part of MC (Collision HepMCEvent HardInfo GenCollision MCParticle GenMCLink MCVertex MCEffTree MCProperty)

  • Information provider: Physics event model task force (Patrick Koppenburg et al.)
  • Reviewers: Gerhard van Raven and Gloria Corti

VELO:

  • Information provider: Chris Parkes
  • Reviewers: Matt Needham, Juan Palacios

ST:

  • Information provider: Matt Needham
  • Reviewers: Chris Parkes, Juan Palacios

OT:

  • Information provider: Jacopo Nardulli
  • Reviewers: Chris Parkes, Juan Palacios

RICH:

  • Information provider: Chris Jones
  • Reviewers: Matt Needham, Alessia Satta

Muon:

  • Information provider: Alessia Satta
  • Reviewers: Olivier Leroy, Chris Jones

Calo:

  • Information provider: Olivier Deschamps
  • Reviewers: Olivier Leroy, Chris Jones

L0, L1 :

  • Information provider: Olivier Callot, Thomas Schietinger, Patrick Koppenburg
  • Reviewers: Olivier Deschamp, Alessia Satta

Timescale

First phase, July:

The information providers set-up a web page with links to relevant information, provide explanations for specific implementations, etc. Please link the web page to this page

Second phase August-September:

The reviewers discuss, ask questions to the subsystems.

Third phase, LHCb software week:

The subsystems give a short summary about their event models. Followed by the report of the reviewers and discussions.

Links

-- MarcoCattaneo - 05 Jul 2005

 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright & 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback