Difference: AndrewsTrigPhotonWorkLog (24 vs. 25)

Revision 252009-08-13 - AndrewHamilton

Line: 1 to 1
 
META TOPICPARENT name="AndrewHamilton"

Andrew's Trig Photon Work Log

Line: 6 to 6
 

TrigL2Photon Changes

Changed:
<
<
Problem: TrigL2PhotonFex uses the FexAlgo::acceptInput method which "pre-selects" TrigEMClusters that produce TrigPhotons. This has the following effects:
  • TriggerElements that contain TrigEMClusters that fail the pre-selection do not get de-activated (only Hypo's can de-activate a TE), so we get left with active TE's that have no outputTE
>
>
Problem: TrigL2PhotonFex uses the FexAlgo::acceptInput method which "pre-selects" TrigEMClusters that produce TrigPhotons. This has the following effects:
  • TriggerElements that contain TrigEMClusters that fail the pre-selection do not get de-activated (only Hypo's can de-activate a TE), so we get left with active TE's that have no outputTE
  * the pre-selection cuts do not get monitored (because they are in the Fex) * it is an unnecessary difference between electrons and photons
Changed:
<
<
Solution: Split TrigL2PhotonFex into TrigL2CaloHypo and TrigL2PhotonFex. Now, the photon slice is using the same TrigL2CaloHypo code as the electrons, obviously, different configurations are possible (i.e. L2CaloHypo_gX)
>
>
Solution: Split TrigL2PhotonFex into TrigL2CaloHypo and TrigL2PhotonFex. Now, the photon slice is using the same TrigL2CaloHypo code as the electrons, obviously, different configurations are possible (i.e. L2CaloHypo_gX)
  Packages Edited:
Changed:
<
<
>
>
  • TrigHypothesis/!TrigEgammaHypo
  • TrigEvent/!TrigParticle
  • TriggerCommon/!TriggerMenuPython
  Packages Affected:
Changed:
<
<
>
>
  • TrigEvent/!TrigParticleTPCnv (not sure this is really affected...)
  • TrigEvent/!TrigEventAthenaPool (not sure this is really affected...)
 
Changed:
<
<
TrigL2PhotonFex (.cxx and .h)
>
>
TrigL2PhotonFex (.cxx and .h)
  • remove acceptInput method which filtered the TrigEMCluster, so we should add a TrigL2CaloHypo for the photons
  • change extraction of TrigPhoton variables from the TrigL2PhotonFex to the TrigPhoton constructor (to be same as TrigElectron)
 
  • there is no longer a cut in the dEta and dPhi between the cluster and RoiDescriptor (to be same as electron)
Changed:
<
<
TrigPhoton (.cxx and .h)
>
>
TrigPhoton (.cxx and .h)
 
  • add new constructor that take just the roi and the link to the cluster and fills the data members
Changed:
<
<
>
>
  • TrigPhoton et changed from "cluster->energy / cosh( fabs( cluster->eta ) )" to "cluster->et"
  • TrigPhoton's rCore will now give default of 0 instead of -1 (like !!TrigElectron)
  • NOTE: do I need to recompile TrigEventAthenaPool and TrigParticleTPCnv...
 
Changed:
<
<
TrigL2PhotonFexConfig:
>
>
TrigL2PhotonFexConfig:
 
  • this is just a dummy class because the Fex just passes everything through
Changed:
<
<
TrigL2CaloHypoConfig:
  • added photon hypo configurations g4 and g7 which just cut on the et of the cluster (like TrigPhotonFex used to do)
>
>
TrigL2CaloHypoConfig:
  • added photon hypo configurations g4 and g7 which just cut on the et of the cluster (like TrigPhotonFex used to do)
 
Changed:
<
<
TriggerMenuPython:
>
>
Change Hypo Config Naming:
  • because I'm already modifying the package structure, I will make the naming of the Fex and Hypo config files more logical
    • TrigL2IDCaloHypoConfig -> TrigL2ElectronHypoConfig + TrigL2ElectronFexConfig
    • TrigL2IDCaloHpyoMonitoring -> TrigL2ElectronHypoMonitoring
    • TrigEFEgammaHypoConfig -> TrigEFElectronHypoConfig
    • TrigEFEgammaHypoMonitoring -> TrigEFElectronHypoMonitoring
  • this means I need to change:
    • TriggerMenuPyton: share/generateChainDef.py, python/ElectronDef.py, python/UnseededEgamma.py

TriggerMenuPython:

  • edit PhotonDef.py (it's linked to Photon.py in TrigEgammaHypo)
 

Questions:

Changed:
<
<
>
>
  • TrigL2PhotonFex: who deletes pointers to TrigPhotonContainer and TrigPhoton?
  • Should default cuts be added to hypo config classes (like TrigL2CaloHypoConfig.py)
 

To-Do List

 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright & 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback