Review of C++ statics Accessed by Modules

Complete: 4

Purpose of Page

This is meant to collect all known C++ statics which are accessed by cmsRun modules during Event processing.

Issued found by Tool

The following table contains the statics which can affect modules while processing Events. This was abstracted from http://home.fnal.gov/~gartung/scan-build/functions-override.txt.

Class with static Package Comments
CocoaAnalyzer Alignment/CocoaApplication ALIUtils::debug and ALIUtils::report are being accessed in a static way, and are also modified by static functions, it should be implemented a mutex in the functions that are involved with these variables
Model Alignment/CocoaModel Model::theOptOList, Model::theOpticalAlignments, Model::theMeasurementVector, Model::theCocoaStatus and Model::theEntryVecto are also accessed in a static way, and are also modified by static functions, it should be implemented a mutex in the functions that are involved with these variables
SurveyInputDummy Alignment/SurveyAnalysis test code
TSFit CalibCalorimetry/EcalLaserAnalyzer https://github.com/cms-sw/cmssw/pull/1286
LaserSorter CalibCalorimetry/EcalLaserSorting https://github.com/cms-sw/cmssw/pull/1286
SiStripDetCabling CalibFormats/SiStripObjects https://github.com/cms-sw/cmssw/pull/1309
SiStripFecCabling CalibFormats/SiStripObjects https://github.com/cms-sw/cmssw/pull/1309
DTTTrigSyncTOFCorr CalibMuon/DTDigiSync the variables theVPropWire and theTOFCorrType are members of the class and are not static
EcalMipGraphs CaloOnlineTools/EcalTools edm::Service<> should not be assigned to a static
DTConfigPluginHandler CondCore/DTPlugins https://github.com/cms-sw/cmssw/pull/1313
DTBufferTree<int>*> CondFormats/DTObjects in CondFormats/DTObjects/interface/DTBufferTree.icc defaultContent, defaultContent is set in a static way and then is used to initialize bufferContent
L1TriggerKey CondFormats/L1TObjects https://github.com/cms-sw/cmssw/pull/1355
FebLocationSpec CondFormats/RPCObjects https://github.com/cms-sw/cmssw/pull/1355
SiStripFedCabling CondFormats/SiStripObjects https://github.com/cms-sw/cmssw/pull/1355
L1MuGMTReadoutCollection DataFormats/L1GlobalMuonTrigger https://github.com/cms-sw/cmssw/pull/1320
reco::PFCluster DataFormats/ParticleFlowReco documented here
DDName DetectorDescription/Core https://github.com/cms-sw/cmssw/pull/1450
CommissioningTask DQM/SiStripCommissioningSources https://github.com/cms-sw/cmssw/pull/1384
Benchmark DQMOffline/PFTau affects PFMETDQMAnalyzer
MatacqProducer EventFilter/EcalRawToDigi https://github.com/cms-sw/cmssw/pull/1448
FBaseSimEvent FastSimulation/Event fixed by lveldere https://github.com/cms-sw/cmssw/pull/1368
HcalRecHitsMaker FastSimulation/CaloRecHitsProducer https://github.com/cms-sw/cmssw/pull/1418
FastL1Region FastSimulation/L1CaloTriggerProducer https://github.com/cms-sw/cmssw/pull/1421
TGeoMgrFromDdd Fireworks/Geometry https://github.com/cms-sw/cmssw/pull/1445
gen::Cascade2Hadronizer GeneratorInterface/CascadeInterface const char* Cascade2Hadronizer::classname() const returns a string literal, is it ok as it is now?
CosmicGenFilterHelix GeneratorInterface/GenFilters https://github.com/cms-sw/cmssw/pull/1447
vpp_generated_2010_01_22 L1Trigger/CSCTrackFinder wrap function uses statics to store data between each call and is designed to be called serially
  statics could be made member data but code is generated and requires changing the model
vpp_generated_2012_01_31 L1Trigger/CSCTrackFinder same as above
CSCTFPtMethods L1Trigger/CSCTrackFinder has static vpp_generated_* members that can't be made const
CSCTFSPCoreLogic L1Trigger/CSCTrackFinder https://github.com/cms-sw/cmssw/pull/1283
CSCAnodeLCTAnalyzer L1Trigger/CSCTriggerPrimitives test code
CSCCathodeLCTAnalyzer L1Trigger/CSCTriggerPrimitives test code
CSCCathodeLCTProcessor L1Trigger/CSCTriggerPrimitives test code
CSCTriggerPrimitivesReader L1Trigger/CSCTriggerPrimitives https://github.com/cms-sw/cmssw/pull/1294
L1GtAlgorithmEvaluation L1Trigger/GlobalTrigger https://github.com/cms-sw/cmssw/pull/1342
L1MuGMTConfig L1Trigger/GlobalMuonTrigger static data members set to default and then set to input parameters
  can't have concurrent instances with different input parameters
WriteVHDL L1TriggerConfig/RPCTriggerConfig test code
magfieldparam::poly2d_base MagneticField/ParametrizedEngine class is meant to be instantiated once, MFProducer which instantiates needs to be global
JetPlusTrackCorrector RecoJets/JetPlusTracks https://github.com/cms-sw/cmssw/pull/1422
PileupJetIdAlgo RecoJets/JetProducers https://github.com/cms-sw/cmssw/pull/1429
GeneralBinFinderInPhi RecoMuon/DetLayers fixed already
L1MuonPixelTrackFitter RecoMuon/TrackerSeedGenerator https://github.com/cms-sw/cmssw/pull/1428
CSCHaloAlgo RecoMET/METAlgorithms https://github.com/cms-sw/cmssw/pull/1430
PFClusterAlgo RecoParticleFlow/PFClusterProducer https://github.com/cms-sw/cmssw/pull/1431
CaloTauSelectorDefinition RecoTauTag/TauTagTools https://github.com/cms-sw/cmssw/pull/1432
MeasurementTrackerEventProducer RecoTracker/MeasurementDet https://github.com/cms-sw/cmssw/pull/1433
SimpleVertexTree RecoVertex/KalmanVertexFit https://github.com/cms-sw/cmssw/pull/1434
EcalSelectiveReadout SimCalorimetry/EcalSelectiveReadoutAlgos https://github.com/cms-sw/cmssw/pull/1435
EcalSelectiveReadoutProducer SimCalorimetry/EcalSelectiveReadoutProducers https://github.com/cms-sw/cmssw/pull/1438
DTDigitizer SimMuon/DTDigitizer https://github.com/cms-sw/cmssw/pull/1439
GaussNoiseProducerFP420 SimRomanPot/SimFP420 https://github.com/cms-sw/cmssw/pull/1440
MaterialAccountingGroup SimTracker/TrackerMaterialAnalysis fixed already
TrackerHitProducer Validation/TrackerHits https://github.com/cms-sw/cmssw/pull/1441

Review of Issues

In this section we provide the reasons a particular issue could not be trivial fixed and offer suggestions for how it might be changed.

-- ChrisDJones - 31 Oct 2013

Edit | Attach | Watch | Print version | History: r26 < r25 < r24 < r23 < r22 | Backlinks | Raw View | WYSIWYG | More topic actions
Topic revision: r26 - 2013-11-15 - DavidMendez
 
    • Cern Search Icon Cern Search
    • TWiki Search Icon TWiki Search
    • Google Search Icon Google Search

    CMSPublic All webs login

This site is powered by the TWiki collaboration platform Powered by PerlCopyright & 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback