HltAlgorithm.cpp: typo on a property: vertices is not in capital letters in declareProperty("OutputverticesName", m_outputVerticesName = "");
Clarity
Find an appropiate name for AppendedValues... document and name everything accordingly. (HR 07/03/2007)
Rename:
monitor() to something like fillWithAppendedValues() (HR 07/03/2007)
map() to appendValues() (HR 07/03/2007)
size() to monitorContainerSize() (HR 07/03/2007)
Give more informative names to vertex "banks"? (HR 07/03/2007)
Change location of 2D VELO tracks from "Rec/Track/RZVelo" to "Hlt/Track/RZVelo" (HR 07/03/2007)
Naming convention to distinguish locations of Pat and Hlt containers? (HR 07/03/2007)
Nomenclature about passed/accepted (HR 09/03/2007)
What does long m_nCandidates in HltBaseAlg? If it is really the minimum number of candidates required, put it in the name of the variable (HR 13/03/2007)
beginExecute and endExecute are needed? If so, clarify who does what: HltBaseAlgo and HltAlgorithm. (HR 13/03/2007)
Robustness
size() must produce a WARNING when size = 0, as this is not expected in normal running of HLT (HR 07/03/2007)
Missing tools
More information at the end: number of candidates found, number of standard input and output objects read/written (HR 09/03/2007)
Add a default PatOutputVertices to the base class (HR/JH 09/03/2007)
Heritage of AppendedValues to daughter tracks and vertices (HR 07/03/2007)
Vertex ancestry by vertices?
Clever functions not to recompute AppendedValues (HR 07/03/2007)
Reactivate candidatesFound (HR 07/03/2007)
Counter for nCandidates per event
Set filter to passed if nCandidates>minNCandidates
Histogram nCandidates per event
Count nTotalCandidates (cumulated in all events)
What is the use of setDecision on top of setFilterPassed?