LHCb Physics Event Model Comments on the MathCore Vector and the Root Linear Algebra Classes
Introduction
The
review of the physics event model is the right opportunity to also revise the usage of CLHEP in the Physics Event Model (and also an incent to totally abandon CLHEP in LHCb software). The merger of SEAL and ROOT is supposed to provide a new library of vectors and linear algebra (matrices) that overcome the known CLHEP problems (see below). There is a test version of the vector classes available, while the liear algebra matrices are part of the ROOT TObject classes for quite some time.
We have tried to use these classes in the new Physics Event Model but have found too many problems.
The contact person far all these issues is Juan Palacios.
MathCore Vector Classes
Although they have a little complicated structure (many templates and typedefs) which makes it sometimes difficult to know which class one is actually using, the MathCore Vector Classes are quite well designed. Also the classes have sometimes silly names (XYZTVector for instance), which we suggest to hide behind an additional layer of typedefs.
There are a few small problems that can be easily fixed:
- We found an inconsistency in the behaviour of the typedefs for Vector3Ds and LorentzVectors. If Ione includes MathCore/Vector3D.h in the code, this includes MathCore/Vector3Dfwd.h, so one gets the typedefs XYZVector, XYZVectorF, etc. However, if one includes MathCore/LorentzVector.h, one does not get access to the typedefs as this file does not include MathCore/LorentzVectorfwd.h.
- A XYZTPoint is missing. That would be nice to have for MC truth.
- The Vec() method in XYZTVector is not const
- There is an Eta() method in the LorentzVector, but no Gamma() and Beta().
Root Linear Algebra Classes
- All classes are TObjects, which pulls the whole of ROOT into our event model. Is that necessary?
- Internally there are exported typedefs like Assert which overwrites the Assert method in GaudiTool.
- We would like to be able to get a sub-matrix by reference. This is presently implemented, but the interface of the method is quite strange.
- The linear algebra classes seem not to be compatible with the mathcore classes. There is no way to multiply a matrix and a vector. (?)
Links
Appendix
CLHEP problems
A brief reminder of the problems with CLHEP:
- No constructor from Point to Vector. A point minus a point is a point (!). The following code calculating an impact parameter does not compile anymore:
HepPoint3D P(0,0,0), B(1,2,3);
Hep3Vector V(0.8,0.6,0.0);
Hep3Vector D = B - A; // does not compile with CLHEP 1.9
double IP = (D.cross(V.unit()).mag();
One needs to:
HepPoint3D TMP = B - A ; // point - point is point (!?)
Hep3Vector D(TMP.x(),TMP.y(),TMP.z()) ; // object-oriented programming ?
CRJ : Note, this does work if you use HepVector3D instead of Hep3Vector
HepPoint3D P(0,0,0), B(1,2,3);
HepVector3D V(0.8,0.6,0.0);
HepVector3D D = B - A; // does work
double IP = (D.cross(V.unit()).mag();
I think the confusion is "why are there 2 versions of 3-vectors in CLHEP ?"
--
ChrisRJones - 20 Sep 2005
Conclusion: Include
SymMatrix
at the very beginning of the file.
- The internal representation of a HepLorentzVector is (momentum, energy) which causes precision problems for photons for instance.
-- PatrickKoppenburg - 09 Sep 2005