Principal Reviewer
Kurt Rinnert
Code Location
Package |
Functionality |
Maintainer |
Det/FTDet |
The detector element package. |
Plamen Hopchev |
Event/FTEvent |
Contains the FT event classes. |
Eric Cogneras |
FT/FTDigitisation |
Contains the digitisation algorithms. |
Eric Cogneras |
FT/FTDAQ |
The raw bank encoder/decoder. |
Olivier Callot |
Review Comments
- Adhere to LHCb conventions for class and variable names.
- Containers should have names which are a plural of the contained objects, e.g. "FTStations" contain FTStation objects/pointers.
- Using namespaces can make code difficult to read - suggested to use a namespace alias to make it clear where a method comes from.
- Strip out obsolete code, example given was "less_Chan" (which also violates naming conventions).
- Variable names should be representative, "aSomething" is sometimes not a good name, especially if dealing with multiple instances of similar objects.
- Debug statements should be protected.
--
PaulSzczypka - 30-May-2012
This topic: LHCb
> WebHome >
LHCbUpgrade >
UpgradeSimulations >
UpgradeSoftwareReviews > UpgradeSoftwareReviewFT
Topic revision: r9 - 2012-06-13 - unknown