Principal Reviewer

Code Location

Package	Project	Functionality
VeloLite/VeloLiteMoniSim	Gauss	monitoring of MCHits
Det/VeloLiteDet	LHCb	detector element
VeloLite/VeloLiteDigitisation	Boole	digitisation and clustering
VeloLite/VeloLiteAssociators	Lbcom	MC truth association
VeloLite/VeloLiteDAQ	Lbcom	raw bank encoding
Event/VeloLiteEvent	LHCb	event classes (temporary location)

The VeloLiteChannelID (VeloLiteChannelID.xml) is a copy of VeloChannelID, but with 12 bits for encoding the strip number.

Change naming scheme from VeloLite to VL in order to be consistent.
Should only have one decoder method (with a test?).
Cleanup methods which are not used. Only add them when necessary.
Do not inherit code from other packages - ensure the package is self-contained.
Suggestion to form truth table as part of the event class.
Granulate the monitoring. Not many people want to look at the expert monitoring histograms and they take up space in productions. Possibly better to output a summary which can be parsed and a flag to book/fill/write the expert histograms.
Code footprint - do you really to need to use an array of doubles rather than floats?
Ensure that each algorithm has a unique name.

Class	Class ID	Description
MCVeloLiteDigit	4301	response of a strip chip channel (charge and ADC value)
VeloStripCluster	4302	equivalent of VeloCluster
VeloStripLiteCluster		equivalent of VeloLiteCluster

Topic attachments
I	Attachment	History	Action	Size	Date	Who	Comment
pdf	2012-06-12_Velo_Lite_Critique.pdf	r1	manage	319.6 K	2012-06-12 - 16:07	PaulSzczypka	Initial Reviewer Critique
pdf	VeloLite.pdf	r1	manage	192.5 K	2012-06-12 - 16:07	PaulSzczypka	Initial Review Code Overview

Topic revision: r8 - 2012-06-13 - PaulSzczypka

Welcome Guest