Principal Reviewer

Olivier Callot

Code Location

Reviewer Comments

• The VeloLiteChannelID (VeloLiteChannelID.xml) is a copy of VeloChannelID, but with 12 bits for encoding the strip number.

Review Comments (notes taken by Paul)

• Change naming scheme from VeloLite to VL in order to be consistent.
• Should only have one decoder method (with a test?).
• Cleanup methods which are not used. Only add them when necessary.
• Do not inherit code from other packages - ensure the package is self-contained.
• Suggestion to form truth table as part of the event class.
• Granulate the monitoring. Not many people want to look at the expert monitoring histograms and they take up space in productions. Possibly better to output a summary which can be parsed and a flag to book/fill/write the expert histograms.
• Code footprint - do you really to need to use an array of doubles rather than floats?
• Ensure that each algorithm has a unique name.

Proposed Event Classes