JuanAldeaSandbox < Sandbox/SandboxArchive < TWiki

Sandbox/SandboxArchive Web>TWikiUsers>JuanAldea>JuanAldeaSandbox (2020-08-30, TWikiAdminUser)

Breaking retrocompatibility
- Code works using the premise that it is looping over hits of one category only, hits are already filtered.
- Removing these nethods
  - const HitPattern & TrackBase::hitPattern() const;
  - const HitPattern & TrackBase::trackerExpectedHitsInner() const;
  - const HitPattern & TrackBase::trackerExpectedHitsOuter() const;
- So instead of calling:
  - trackBase.hitPattern().method();
  - trackBase.trackerExpectedHitsInner().method();
  - trackBase.trackerExpectedHitsOuter().method();
- we would call methods giving a category of hits to loop over:
  - trackBase.hitpattern().method(TRACK_HITS);
  - trackBase.hitpattern().method(EXPECTED_INNER_HITS)
  - trackBase.hitpattern().method(EXPECTED_OUTER_HITS);
  - trackBase.hitpattern().method(ALL_HITS); // ALL_HITS is the default category
- Cleaner & useful but we would need to change tons of code:
Keeping retrocompatibily requires:
- Filtering hits and creating new HitPatterns filled with hits of one category only (TRACKER/EXPECTED_INNER/EXPECTED_OUTER)
  - Lazily created cache --> uses four times more memory at runtime (original + 3 filtered copies), some new/delete time overhead.
  - We can still have the hit category aproach mentioned before by adding a default category:
    - T trackBase.hitpattern().method() { return trackBase.hitpattern().method(this->defaultCategory) };

-- JuanAldea - 24 Feb 2014

Edit | Attach | ~~Watch~~ | Print version | History: r2 < r1 | Backlinks | Raw View | WYSIWYG | More topic actions

Topic revision: r2 - 2020-08-30 - TWikiAdminUser

Sandbox/SandboxArchive

CERN

- Cern Search
- TWiki Search
- Google Search
Sandbox/SandboxArchive All webs

Copyright &© 2008-2023 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
or Ideas, requests, problems regarding TWiki? use Discourse or Send feedback