Example: DICOM


1) Example compiles, runs (?)
	yes

2) External software documentation (if present)
   	...

3) Classification of classes
   List classes specific to demonstrated features:
   
	DicomHandler
	DicomIntersectVolume
   
   List of classes which can be replaced with common ones:
   
   ...
   
4) Messenger classes
   List commands defined in this example: 
   
	/dicom/intersectWithUserVolume (taking 8 parameters)
	/dicom/intersectWithUserVolume (taking 1 parameter)

   List commands which do not work as expected:
   a) not at all
   ...
   
   b) in some G4 phase(s)
   ...
   
5) Code review:
   Report on obsolete code (if present):
   
	1) PhysicsLists should be updated to using G4PhysicsListHelper
   
   Report on inefficient code (if present):

	DicomHandler:
	1)	function Pixel2Density should be separated into two functions with 
		G4int nbrequali, G4double* valuedensity, and G4double* valueCT
		put into the header file. The CT2Density.dat file should be only
		read once in the first half of the split Pixel2density function and
		it should be called in either the constructor or at the beginning of
		ReadFile. In other words, re-opening CT2Density.dat and reading in the data 
		every time for each pixel significantly slows down the program when
		using several files.
 	2)	In reading other CT and PET files than the given examples, not reading in
		the reserved 2 bytes and the element length resulted in bad pixel values in
		the CT rendering.
	3)	In GetMaterialIndex() - if the density passed to the function is larger than
		the max density of dense bone, ii will equal fMaterialIndices.size() (say 10) 
		and this will segfault if that material index is used directly on accessing a 
		vector element (i.e. no vec[10] if vec.size()==10)
	
	DicomIntersectVolume:
	1)	the whole function GetWordsInString() is more easily implemented with:

			// where the passed parameter “delimiter” below is ‘ ‘ (for spaces) or ‘,’ (for commas), etc..
			inline std::vector<std::string> DelimitLine(std::string line, char delimiter)
			{
        			std::vector<std::string> delimitedLine;
        			std::string token;
        			std::istringstream iss(line);
        			while( getline(iss,token,delimiter) ) {
            				if( !token.empty() ) { delimitedLine.push_back(token); }
        			}
        			return delimitedLine;
    			}

   
   Your recommendations to example owner:
   
6) Documentation review:
   Your recommendations to example owner:

   ...
   
7) Comment on the adequacy in its physics domain
   (skip this item if you are not an expert in physics demonstrated 
   in the example):

   ...    
   
8) "Users questions to be addressed in examples"   
   List questions which can be naturally addressed in this example:

   ...