Example: Geant4/examples/extended/persistency/gdml/G04/ 
All comments refer to:
geant 4 release: patch01 for Geant4 9.5 
platform: SLF 6 and UBUNTU

Reviewer: Hans Wenzel


1) Example compiles, runs 
   Yes and a CMakeLists.txt file is provided. Since the new build system is 
   cmake this should be reflected in the readme file for an out of source build:

   building the example:
   mkdir G04-build
   cd G04-build/

   cmake -DGeant4_DIR=/xxx/geant4.9.5.p01-install/lib/Geant4-9.5.1/ \
          /xxx/geant4.9.5.p01/examples/extended/persistency/gdml/G04

   make  gdml_det

remark: since there is only one target for creating an executable (gdml_det) a
simple  make should be sufficient.
To run it:
 export LD_LIBRARY_PATH=.:$LD_LIBRARY_PATH

since we did an out of source build we have to copy the necessary .mac and .gdml 
files to the area where we build the example (G04-build)
cp   /home/wenzel/geant4.9.5.p01/examples/extended/persistency/gdml/G04/*.mac .
cp   /home/wenzel/geant4.9.5.p01/examples/extended/persistency/gdml/G04/auxiliary.gdml .
then 
./gdml_det auxiliary.gdml


2) External software documentation (if present)
   fine. The README file lists all the prerequisites. Since Geant 4 switched 
   to cmake as a build system may be one should mention that to build geant 4
   one should use the flag: 
   -DGEANT4_USE_GDML=ON
   

3) Classification of classes
   List classes specific to demonstrated features:
   
   ...   
   
   List of classes which can be replaced with common ones:
   
   ...
   
4) Messenger classes
   n/a no messenger classes provided 

   List commands defined in this example: 
   ...  
   
   List commands which do not work as expected:
   a) not at all
   ...
   
   b) in some G4 phase(s)
   ...
   
5) Code review:
   Report on obsolete code (if present):
   ...
   
   Report on inefficient code (if present):
   ...
   
   Your recommendations to example owner:
   
   
6) Documentation review:
   Your recommendations to example owner:
   As mentioned above the documentation should reflect the use of cmake 
   to build the example. 
   
7) Comment on the adequacy in its physics domain
   (skip this item if you are not an expert in physics demonstrated 
   in the example):
   ...    
   
8) "Users questions to be addressed in examples"   
   List questions which can be naturally addressed in this example:

   Very nice example how to attach sensitive detectors to a volume using gdml. 
   But I think this is a general enough problem that the Geant 4 collaboration should 
   consider providing a general module (utility) which reads and parses a valid gdml file, 
   builds the geometry, attaches e.g. all the optical properties to volumes and surfaces
   and also attaches sensitive detectors to the volumes. 
   I think instead of having various examples then one would need only one and provide many 
   example gdml files demonstrating the various capabilities. 
   As is too much work required by the end user.