Example:  Geant4/examples/extended/persistency/P02/
All comments refer to:

geant 4 release: patch01 for Geant4 9.5 
platform: SLF 6 and UBUNTU

Reviewer: Hans Wenzel


1) Example compiles, runs (?)
    no and no 
    Unfortunately like for example P01 the CMakeList.txt is not provided.
    I have attached a working version to the twiki page. 
    Didn't try to fix the GNUmakefile provided since we migrate to cmake.
    (so I would just get rid of it completely)
    To create the Makefiles using cmake copy the file
    CMakeLists.txt that is attached to the twiki to the source directory 
    of example P02 then execute: 
    mkdir  /xxx/P02-build
    cd /xxx/P02-build
    cmake -DCMAKE_MODULE_PATH=/xxx/geant4.9.5.p01/cmake/Modules \
          -DGeant4_DIR=/xxx/geant4.9.5.p01-install/lib/Geant4-9.5.1/ 
           /xxx/geant4.9.5.p01/examples/extended/persistency/P02
    and to create the executable: 
    make 
    
    Again the README file should reflect the use of cmake as a build tool. 
    
    I didn't get the example to run!
    To run the example and write out the geometry I tried:
    export LD_LIBRARY_PATH=.:$LD_LIBRARY_PATH
    ./exampleP02 write
    this will create the file geo.root (unfortunately it's empty) 
    Since the root file was empty I tried to read the one 
    provided with the source: 
    cp  /xxx/geant4.9.5.p01/examples/extended/persistency/P02/geo.root  .
    ./exampleP02 read
    but this resulted in 
     *** Break *** segmentation violation
    At this point I gave up. Will comment on the points below once I get it running. 

2) External software documentation (if present)
   ...

3) Classification of classes
   List classes specific to demonstrated features:
   
   ...   
   
   List of classes which can be replaced with common ones:
   
   ...
   
4) Messenger classes
 
   n/a (no messenger classes specific to this example.).
   List commands defined in this example: 
   ...  
   
   List commands which do not work as expected:
   a) not at all
   ...
   
   b) in some G4 phase(s)
   ...
   
5) Code review:
   Report on obsolete code (if present):
   ...
   
   Report on inefficient code (if present):
   ...
   
   Your recommendations to example owner:
   ...
   
6) Documentation review:
   Your recommendations to example owner:
   ...
   
7) Comment on the adequacy in its physics domain
   (skip this item if you are not an expert in physics demonstrated 
   in the example):
   ...    
   
8) "Users questions to be addressed in examples"   
   List questions which can be naturally addressed in this example:
   
   I think it's a nice example. I pretend to use it to provide provenance to my data by storing the geometry 
   information with the output file